Skip to content

Add a e2e test for external fw specified by a fwid #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tchinmai7 wants to merge 1 commit into from
Closed

Add a e2e test for external fw specified by a fwid #194

tchinmai7 wants to merge 1 commit into from

Conversation

@tchinmai7
Copy link
Contributor

@tchinmai7 tchinmai7 commented Mar 20, 2024

General:

Add a e2e test for external fw

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@rahulait
Copy link
Contributor

rahulait commented Dec 10, 2024

This test is now included in #253

@rahulait
Copy link
Contributor

rahulait commented Dec 11, 2024

Since the chainsaw PR is merged and this test is already included there, this PR can be closed.

@rahulait
Copy link
Contributor

rahulait commented Jan 2, 2025

Closing this PR as its already implemented with chainsaw tests.

@rahulait rahulait closed this Jan 2, 2025
@rahulait rahulait deleted the add-a-e2e-test branch January 9, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tchinmai7 @rahulait